range() with float step should return an array of floats
#3447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been marked as ready for review. |
mvorisek
reviewed
Sep 16, 2024
There was a problem hiding this comment.
The type depends on PHP version - https://3v4l.org/vIjsa
if step could be intepreted as int, int is used
and if either start or stop (or step after the transformation to int described above) is float, the type is always list<float>
There was a problem hiding this comment.
while I agree with your sentiment I think the extension is already too complicated because it tries to be too smart for the value it produces (and I am pretty sure the already existing logic contains more bugs then the one this PR fixes)
ondrejmirtes
requested changes
Sep 17, 2024
There was a problem hiding this comment.
This should be non-empty-list<float>.
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes phpstan/phpstan#11692